您的位置:首页 > 编程语言

通过调试的重构代码(设计是对的,但是实现过程却有诸多的问题)

2014-01-02 16:32 441 查看
#!/usr/bin/env python

class Processor:
def __init__(self, processor):
self.processor = processor

def isAllowSend(self, message, setChargeFlag):
pass

class WhildListProcessor(Processor):
def isAllowSend(self, message, setChargeFlag):
print "WhildListProcessor.isAllowSend is Running"
if message.sender in (1,2):
print "WhildListProcessor.isAllowSend return True"
return True

return self.processor.isAllowSend(message, setChargeFlag)

class DateProcessor(Processor):
def isAllowSend(self, message, setChargeFlag):
print "DateProcessor.isAllowSend is Running"
if message.date > "20130101":
print "DateProcessor.isAllowSend return False"
return False

return self.processor.isAllowSend(message, setChargeFlag)

class DefaultProcessor(Processor):
def isAllowSend(self, message, setChargeFlag):
print "DefaultProcessor.isAllowSend is Running"
setChargeFlag(message)
print "DefaultProcessor.isAllowSend return True"
return True

def getProcessor():
return WhildListProcessor(DateProcessor(DefaultProcessor(None)))

class Message:
def __init__(self, sender):
self.sender   = sender
self.isSend   = False
self.isCharge = False
self.date     = "20110201"

def setChargeFlag(message):
print "Set Charge Flag"
message.isCharge = True

def setSendFlag(message):
print "Set Send Flag"
message.isSend = True

def run():
message = Message(10)
processor = getProcessor()
if (processor.isAllowSend(message, setChargeFlag)):
setSendFlag(message)

run()


这是前一篇博客里的代码,通过实际调试之后的代码,下列的体会:

1, 设计是对的

2, 我在实现设计的过程里却有bug产生

  2,1 WhildListProcessor 等类的isAllowSend方法没有return

  2,2 DefaultProcessor没有继承我的Processor类

  2,3 既然增加了DateProcessor类并检查了Message.date属性,却没在Message类里增加date属性

  2,4 出现一个拼写错误 DefaultProcessor 写成 DefaltProcessor

实际上我的多数bug都是这么产生的,是我的性格太粗疏了吗? :( 另外,各位看官,这是一个设计模式,您看出来了吗
内容来自用户分享和网络整理,不保证内容的准确性,如有侵权内容,可联系管理员处理 点击这里给我发消息
标签: 
相关文章推荐